fix: wire SSR route components - #728
Conversation
|
Warning Review limit reached
More reviews will be available in 25 minutes and 35 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results❌ Some benchmarks failed
Updated: 2026-06-14T17:22:36.446Z · Commit: 317ff07 |
Summary
create-croco-appSSR route templates now pass the generated page component value intodefineRoute(), socontainer-fullstackandssr-lambdaapps no longer emit route definitions backed byundefinedcasts or type-only runtime references.Fixes #694
변경 사항
component.satisfies PageRouteDefinitionbefore callingdefineRoute().CrocoDataFntype from@croco/frontend-reactso the SSR Lambda fixture typechecks through the public package entrypoint.create-croco-appand@croco/frontend-react.Verification
pnpm --filter create-croco-app exec vitest run src/tests/templates-build.spec.tspnpm --filter create-croco-app test(7 files, 30 tests)pnpm --filter create-croco-app typecheckpnpm --filter create-croco-app buildssr-lambdapageData.tspnpm --filter @croco/frontend-react test(2 files, 5 tests)pnpm --filter @croco/frontend-react typecheckpnpm --filter @croco/frontend-react buildpnpm checkgit diff --check origin/trunk..HEADpnpm exec changeset status --since origin/trunkauto-changeset, fullpnpm test(195 tasks), fullpnpm typecheck(194 tasks)Self-review
component: undefined, and the oldPage satisfies Pageruntime pattern; the route smoke typechecks both templates with the generatedPagevalue andpageData.ts.CrocoDataFnis an additive public type export for a type already defined in@croco/frontend-react; no runtime dependencies, lockfile entries, environment assumptions, or secrets changed. Patch changesets cover both publishable packages.Risk
Low. The route templates now reference the existing generated component value directly; the only public API surface change is an additive type export used by the existing SSR template fixture.